fix(css): preserve spaces around >= and <= in media query range opera… - #2457
Open
Arpit-mohankar wants to merge 3 commits into
Open
fix(css): preserve spaces around >= and <= in media query range opera…#2457Arpit-mohankar wants to merge 3 commits into
Arpit-mohankar wants to merge 3 commits into
Conversation
…tors Fixes beautifier#2164 Fixes the CSS beautifier collapsing space after range operators (>= <=) inside @media query conditions. Before: @media (width >= 90rem) -> @media (width >=90rem) After: @media (width >= 90rem) -> @media (width >= 90rem) Also normalizes minified input: @media (width>=90rem) -> @media (width >= 90rem) Fixed in both JS and Python implementations.
Author
|
"First-time contributor here, happy to make any changes needed. Please approve the workflows to run CI. Thanks!" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2164
What: CSS beautifier was stripping the space after
>=and<=operators in@mediarange queries.Before:
@media (width >= 90rem)→@media (width >=90rem)After:
@media (width >= 90rem)→@media (width >= 90rem)Also normalizes minified input:
@media (width>=90rem)→@media (width >= 90rem)Changes:
js/src/css/beautifier.js— added compound>=/<=handler inside parenthesespython/cssbeautifier/css/beautifier.py— mirrored fix in Pythontest/data/css/tests.js— added 4 test cases covering spaced and minified input